fix small bug in run.sh + drop support for php < 7.2 + update CHANGELOG

visiblevc / wordpress-starter

A slightly less shitty wordpress development workflow

688 stars 167 forks source link

fix small bug in run.sh + drop support for php < 7.2 + update CHANGELOG #167

Closed dsifford closed 4 years ago

dsifford commented 4 years ago

This PR fixes a small bug in run.sh resulting from a typo in a find flag.

Additionally, this PR drops support for PHP < 7.2 to align with php

Finally, the build script was updated to remove useless cruft and the CHANGELOG was brought up to date.

dsifford commented 4 years ago

Okay, so this got a bit more complicated...

It appears the configuration for php7.4 extensions has diverged from versions below it, so we're no longer able to share dockerfiles anymore.

See here for an example of this. There are other such cases as well.

So have a look at this and let me know what you think @karellm

dsifford commented 4 years ago

Sorry for the delay. Sounds good.

We've been using this at my workplace so I'm able to find and correct issues relatively quickly. I'll be sure to do so if we notice any probs with this.