visiblevc / wordpress-starter

A slightly less shitty wordpress development workflow
688 stars 167 forks source link

docker-compose vs docker compose #184

Open AlecRust opened 3 years ago

AlecRust commented 3 years ago

The wordpress-starter documentation states to use docker-compose command to start i.e.

docker-compose up -d && docker-compose logs -f wordpress

When this command is run though Docker gives this notice:

Docker Compose is now in the Docker CLI, try `docker compose up`

If I switch to using docker compose based on this i.e.

docker compose up -d && docker compose logs -f wordpress

Then I get a different style of output when it's running, and wordpress-starter throws an error and exits:

[+] Running 5/5
 ⠿ Network mysite_default         Created                                                                 3.5s
 ⠿ Volume "mysite_data"           Created                                                                 0.0s
 ⠿ Container mysite_phpmyadmin_1  Started                                                                 5.8s
 ⠿ Container mysite_wordpress_1   Started                                                                10.3s
 ⠿ Container mysite_db_1          Started                                                                 4.8s
wordpress_1  | ERROR: Container running with improper privileges.
wordpress_1  |
wordpress_1  | Be sure your service is configured with the following options:
wordpress_1  | ___
wordpress_1  | services:
wordpress_1  |   wordpress:
wordpress_1  |     cap_add:
wordpress_1  |       - SYS_ADMIN
wordpress_1  |     devices:
wordpress_1  |       - /dev/fuse
wordpress_1  |     # needed on certain cloud hosts
wordpress_1  |     security_opt:
wordpress_1  |       - apparmor:unconfined
wordpress_1  | ___
wordpress_1  |
wordpress_1  | OR (use first option if possible)
wordpress_1  | ___
wordpress_1  | services:
wordpress_1  | wordpress:
wordpress_1  |     privileged: true
wordpress_1  | ___
wordpress_1  |
✨  Done in 121.69s.

In my docker-compose.yml my wordpress service is already configured as-per the first example (with SYS_ADMIN etc.).

Does wordpress-starter not support the new docker compose over docker-compose?

jaschahuisman commented 2 years ago

Hi, I have the same issue here, and in my case there is not even a difference between the usage of docker compose or docker-compose. Did you find any solution to fix this?

AlecRust commented 2 years ago

Last time I ran a project using this was a few months ago, and I think I just used docker-compose which worked at the time. Sounds like maybe Docker has changed since then.

dsifford commented 2 years ago

FYI: I don't have owner privileges to this repo, but this project is going to probably need a new regular maintainer because I don't use wordpress (or this project) in my day to day job anymore.

karellm commented 2 years ago

I'm open to grant owner privileges to whoever is willing to take over. It might need to move out of the visiblevc organization too though.

jaschahuisman commented 2 years ago

It still works on my macos machine. Only having this issue on my Windows 10 x64 machine. Is there someone else who can test/recreate this problem on a Windows machine?