A pull request to address changes in the current generation of c++ compilers (g++ versions 6 and 7, in particular). Because of the better code analysis done by these compilers (e.g., printf style format / argument type matching analysis), many of these compiler changes result in more and better warnings. Unfortunately, other changes result in code that no longer works. Specifically, as noted in issue #35, the newest versions of g++ (versions 6 and up) as well as potentially other c++ compilers silently refuse to emit code to test the nullness of this pointers. This pull request addresses the resulting issues and some of the opportunities for improvement in the context of the release 8.1.x code line.1
The code submitted here passes basic database bootstrap and other unit tests; however, additional examination of the code and in-the-wild testing is still in order.
1 Note that at least one set of compilation issues - those addressed by commit 4cae07c - have been dealt with by defining them away, at least for now.
A pull request to address changes in the current generation of c++ compilers (g++ versions 6 and 7, in particular). Because of the better code analysis done by these compilers (e.g., printf style format / argument type matching analysis), many of these compiler changes result in more and better warnings. Unfortunately, other changes result in code that no longer works. Specifically, as noted in issue #35, the newest versions of g++ (versions 6 and up) as well as potentially other c++ compilers silently refuse to emit code to test the nullness of this pointers. This pull request addresses the resulting issues and some of the opportunities for improvement in the context of the release 8.1.x code line.1
The code submitted here passes basic database bootstrap and other unit tests; however, additional examination of the code and in-the-wild testing is still in order.
1 Note that at least one set of compilation issues - those addressed by commit 4cae07c - have been dealt with by defining them away, at least for now.