search

visionmedia / bytes.js

node byte string parser
MIT License
461 stars 57 forks source link

Fixes #31 #32

Closed theofidry closed 8 years ago

theofidry commented 8 years ago

Fixes #31.

dougwilson commented 8 years ago

Cool. This is going to be considered a major version bump, in my mind, due to the regular expression parsing change. For example, "3 bytes" would have worked before, but now it needs to be just "3b"

theofidry commented 8 years ago

Fair enough. Hacky way to use it but way to use it nonetheless.

dougwilson commented 8 years ago

I agree, which is why I'm :+1: for making the parsing stricter :)

dougwilson commented 8 years ago

Plus, there are a bunch of changes all mixed together in this pull request that can get released as a last 2.x, which should be good to have. For example, the .format(NaN) fix.