Added option to insert a space between number and unit

visionmedia / bytes.js

node byte string parser

MIT License

461 stars 57 forks source link

Added option to insert a space between number and unit #35

Closed glegrain closed 8 years ago

dougwilson commented 8 years ago

Thanks! Looks good, just a few nits.

glegrain commented 8 years ago

Thank you for your comments. I pushed the changes you suggested. Let me know if I should change anything else.

dougwilson commented 8 years ago

Thanks, @glegrain, merging now! I just realized an eve better option would be unitSeparator, which would let people use any character, not just a space or no space! I'm simply going to rewrite your commits for this, and you'll still be the author, unless you object to that.

glegrain commented 8 years ago

Awesome! Indeed, that's an even better solution that I haven't thought of.