search

visionmedia / express-resource

Resourceful routing for Express
1.41k stars 140 forks source link

Fix Windows support for mapped and built-in URLs #43

Closed mscdex closed 12 years ago

mscdex commented 12 years ago

... such as "/users/edit" and "/users/1/foo"

Fixes #41

tj commented 12 years ago

we definitely shouldn't be inlining a util like this, why cant we just arr.join('/') or similar

mscdex commented 12 years ago

Yeah I know inlining isn't ideal, but path.join does more than just arr.join('/'). It's your call, but this is definitely a significant issue on Windows.

tj commented 12 years ago

yeah I know, I shouldn't have been using join() for anything url related, definitely a bug on my part