visionmedia / expresso

use mocha
http://visionmedia.github.com/expresso
759 stars 89 forks source link

consider removing jscoverage dependency #110

Open weepy opened 13 years ago

weepy commented 13 years ago

main problem it's compilation step is a bit annoying . especially when other packages depend on it ( e.g. socket.io)

tj commented 13 years ago

socket.io depends on it as a non-devDep? I agree it's annoying, no good substitution for now though. I wish npm could pass a flag to ignore it somehow since it really is optional

weepy commented 13 years ago

no - just for testing. substitution is to remove it as a dependency and have something like :


if(we_are_doing_jscov) {
  var jscov = require("jscov")
  if(!jscov) {
   console.log("Sorry you need to install jscov (hint: npm install jscov)")
   exit() 
  }
}
tj commented 13 years ago

hmm well for testing it should be in devDependencies

tj commented 13 years ago

looks like he does have it in dev-deps

weepy commented 13 years ago

yes -- seems it has to compile it whenever you do npm link or npm install for socket.io

On Tue, Jun 21, 2011 at 4:47 PM, visionmedia < reply@reply.github.com>wrote:

looks like he does have it in dev-deps

Reply to this email directly or view it on GitHub: https://github.com/visionmedia/expresso/issues/110#issuecomment-1411316

tj commented 13 years ago

well yeah if you npm install within the directory, it installs the dev deps so you can work on the project, i've never used npm link though

c4milo commented 13 years ago

+1 jscoverage should be optional, the compilation is really annoying and takes a lot, at least on my machine.

benatkin commented 13 years ago

I think the fact that so few people have chimed in on this issue shows how node programmers are fine with running extensions, which is a good thing. It means it's compiling smoothly. I would also like it to be optional, though, because it would speed up the time from cloning a repo to running tests.

tj commented 13 years ago

would be nice if some deps could be specified optional in npm, npm install expresso --without-jscov or something. I have a half finished pure-js version of jscov so hopefully that gets done soon

slaskis commented 13 years ago

Yeah it would be great if it could be ignored somehow because I can't npm install expresso on no.de (fails with config.mk:167: ref-config/SunOS5.11_i86pc.mk: No such file or directory)

willwhite commented 13 years ago

@kkaefer, any thoughts on breaking coverage out into another tool to make expresso complication faster and easier?

c4milo commented 13 years ago

+1 for @willwhite proposal. @visionmedia what about creating expresso-coverage as a plugin for expresso?

dsc commented 13 years ago

Any big reason not to prompt the user and install it ourselves on --cov? The call to npm install node-jscoverage is complicated by wanting to install it globally if expresso was installed with -g, but that's not more than checking if our package prefix is npm prefix -g, yeah?