visionmedia / expresso

use mocha
http://visionmedia.github.com/expresso
759 stars 89 forks source link

Fixing --serial command. TODO added #175

Closed AnthonyAkentiev closed 10 years ago

AnthonyAkentiev commented 11 years ago

When running tests with --serial parameter -> causes error because assert object is NULL.

Also i've found 2nd bug with --serial execution. In case test is not calling 'beforeExit' -> test would always fail with "test timed out" error. I haven't fixed that yet, but wrote comment.

tj commented 11 years ago

might want to check out mocha this lib is just sticking around for historical reasons but it was a quick hack

AnthonyAkentiev commented 11 years ago

Hehe. Yeah, i saw that comment. Ok, i will check Mocha. I kind of like expresso, it is so easy to use... Can you merge my pull-request?

bithavoc commented 10 years ago

+1

tj commented 10 years ago

mocha is equally easy to use, this lib is deprecated

bithavoc commented 10 years ago

@visionmedia if the library is deprecated, we should add this to Readme.md.

In fact, I'm actually using mocha and just googled assert.isDefined and expresso came up first, would you consider adding these additional assertions to mocha?

The code is right here: https://github.com/visionmedia/expresso/blob/master/bin/expresso#L312

I can send a pull request to mocha.

tj commented 10 years ago

it says to use mocha in the readme. Nah there's a lot of different libs that can be used with mocha for assertions, assert(null != foo) from core's assert lib works for that though