search

visionmedia / move.js

CSS3 backed JavaScript animation framework
http://visionmedia.github.com/move.js/
4.72k stars 686 forks source link

deprecate Move.version #29

Open yields opened 10 years ago

axelpale commented 9 years ago

May I ask why?

Personally I see greater pros than cons in having Move.version.

For example in studying the issue #72 I had to figure out why Example 1 works in public documentation but not in my local clone of 0.4.0. Without move.version I would had hard time to figure out that the public documentation uses version 0.3.2 and to deduct that the issue is caused between 0.3.2 -> 0.4.0.

A downside of having move.version is a slight maintenance overhead as the version needs to be updated manually to index.js, component.json and possibly in near future to package.json.

Another downside is its effect to filesize if we really want to be minimal there.

Therefore, because the aid for debugging, I propose move.version to stay.

axelpale commented 9 years ago

It is bit ironic that now I found out that when the version has been bumped from 0.3.2 to 0.4.0, move.version was left intact in index.js. Therefore now we have no means to figure out whether the public docs uses 0.4.0 or not.