Closed andrepolischuk closed 8 years ago
nice! can we keep the conditionals on one line? otherwise looks good to merge!
I fixed to one line
@andrepolischuk good catch! But IMHO checking for percent/px by the type of value looks confusing for users. I think, the better way is to add px
to the value only if user hasn't specified units. For example if user set -100%
or 20rem
we're just passing it. But if user has just set only digits (no matter string it or integer), then we will add px
to the value before passing.
Please, can you update behaviour to make it more flexible?
And one little note — can you move this logic into helper function in the bottom of the file? It's pretty nice place for DRY 'cause of many duplications :D
Sure
@shuvalov-anton, I fixed
Thanks)
👍
Add percentage values for translate, fix #40