visionmedia / move.js

CSS3 backed JavaScript animation framework
http://visionmedia.github.com/move.js/
4.72k stars 686 forks source link

package.json, npm and browserify support #70

Closed axelpale closed 8 years ago

axelpale commented 9 years ago

This pull request solves issue/41, issue/42 and issue/71, the first two relating to missing package.json, missing npm entry and therefore missing browserify support. The issue/41 has many details about the issue and its solution. After the merge, move.js can be downloaded via npm and used with browserify but still continued to be used with component(1) just as before.

After merge, one more thing is required by you, precious collaborator: npm publish

This pull request includes

A commented 8 years ago

+1 @tj @yields can I merge this pull request and publish it to the npm?

tj commented 8 years ago

added both of you! LMK what the npm usernames are

axelpale commented 8 years ago

@tj Thanks a lot! My npm username is xeli.

axelpale commented 8 years ago

@shuvalov-anton could you publish, I do not have time available until the weekend. Thanks!

A commented 8 years ago

@tj thank you :D shuvalov-anton

tj commented 8 years ago

apparently I dont have access to the npm module either

A commented 8 years ago

@axelpale both move and movejs names are occupied. We should find the other one. Do you have ideas? Mb move.js?

axelpale commented 8 years ago

@shuvalov-anton I would prefer move-js because dash seems to be the convention in npm. For example, search packages with "js" and you get a long list of package names with a dash in them. Same thing happens if you search for "move".

axelpale commented 8 years ago

Btw, I removed false npm installation instructions from Readme.md that got there in this PR. After npm publish, the correct installation instructions should be added back, depending on the name, e.g:

...

With npm:

$ npm install move-js

...

A commented 8 years ago

@axelpale nice. move-js ok for me.

axelpale commented 8 years ago

@shuvalov-anton Now it is published \o/

A commented 8 years ago

Great! bicho-6