Closed axelpale closed 8 years ago
+1 @tj @yields can I merge this pull request and publish it to the npm?
added both of you! LMK what the npm usernames are
@shuvalov-anton could you publish, I do not have time available until the weekend. Thanks!
@tj thank you :D shuvalov-anton
apparently I dont have access to the npm module either
@axelpale both move
and movejs
names are occupied. We should find the other one. Do you have ideas? Mb move.js
?
@shuvalov-anton I would prefer move-js
because dash seems to be the convention in npm. For example, search packages with "js" and you get a long list of package names with a dash in them. Same thing happens if you search for "move".
Btw, I removed false npm installation instructions from Readme.md that got there in this PR. After npm publish
, the correct installation instructions should be added back, depending on the name, e.g:
...
With npm:
$ npm install move-js
...
@axelpale nice. move-js
ok for me.
@shuvalov-anton Now it is published \o/
Great!
This pull request solves issue/41, issue/42 and issue/71, the first two relating to missing package.json, missing npm entry and therefore missing browserify support. The issue/41 has many details about the issue and its solution. After the merge, move.js can be downloaded via npm and used with browserify but still continued to be used with component(1) just as before.
After merge, one more thing is required by you, precious collaborator:
npm publish
This pull request includes
require('emitter')
byrequire('component-emitter')
and similar as discussed in issue/41, providing compatibility for both component(1) and node/commonjs/browserify.remotes
from component.json because the public component must not contain any remotes. Ifremotes
exists, runningcomponent install
produces errorno remote found for dependency ...
.make move.js
andmake move.min.js
. Apparently a few extra kilobytes were shaved off as well (28 kB -> 26 kB and 16 kB -> 14 kB).