search

visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

Prevent similar looking domains to trigger page callbacks #437

Closed matthewp closed 6 years ago

matthewp commented 6 years ago

This fixes #407. Previously sameOrigin() was returning false positives due to depending on an indexOf() === 0. This uses the URL constructor (falling back to an anchor) for better accuracy.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 89.61% when pulling 4d03546875eaf17bfdc68b06b7f6b5c718ba3984 on diff-domain into 6ca14c1355c37d3a6ddc838d478d0ef85057f5ac on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 89.61% when pulling 4d03546875eaf17bfdc68b06b7f6b5c718ba3984 on diff-domain into 6ca14c1355c37d3a6ddc838d478d0ef85057f5ac on master.

paulocoghi commented 6 years ago

Excellent!