search

visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

Few conditions to improve nodejs support #440

Closed PaulMaly closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 89.873% when pulling ce4b4093199328b3c8bf75b0334e9e2bd034c7bd on PaulMaly:master into 350344212c9316d949f0857fbb68ec051b905a33 on visionmedia:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 89.873% when pulling ce4b4093199328b3c8bf75b0334e9e2bd034c7bd on PaulMaly:master into 350344212c9316d949f0857fbb68ec051b905a33 on visionmedia:master.

PaulMaly commented 6 years ago

Made the code is a little bit pretty.

matthewp commented 6 years ago

Perfect, thank you! Would be interested in how you are using page.js in Node. I might want to add a few Node tests in the future. Maybe create an issue?

matthewp commented 6 years ago

I plan on doing a patch release tomorrow btw.

PaulMaly commented 6 years ago

@matthewp Thanks, it would be great. I'm glad that I able to come back to the main repo.

Would be interested in how you are using page.js in Node. I might want to add a few Node tests in the future. Maybe create an issue?

Sure, but nothing special there.

matthewp commented 6 years ago

1.7.2 is out and contains this fix: https://github.com/visionmedia/page.js/releases/tag/1.7.2

PaulMaly commented 6 years ago

@matthewp Thanks!