search

visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

upgrade the path-to-regexp version #462

Open yoyo837 opened 6 years ago

yoyo837 commented 6 years ago

Please upgrade the path-to-regexp version, there are some problems with the old version.

like * for 404 handler

page('*', function(context, next) {
})
aldebaran798 commented 6 years ago

What problem have you? I use the asterisk path on end of page.js routes settings and don't have problems

matthewp commented 6 years ago

Same here, I'm pretty sure we have tests for this. Not opposed to upgrading the path-to-regexp dep of course.

dlockhart commented 3 years ago

Any way upgrading path-to-regexp could be prioritized? This is causing multiple versions of isarray to be included in our builds, which is a dependency of older versions of path-to-regexp. The latest version has no dependencies at all.