Use event.composedPath as a fallback in onclick handler

[dthorne]

Before falling back to e.target from e.path use e.composedPath. This allows the onclick handler to work for browsers using ShadyDom AND Polymer 2.

IF I use Polymer 2 and Page.js in FF or Safari then e.path doesn't exist because there is no ShadowDOM. e.target is the Top-most shadow DOM and is therefore not helpful.

[coveralls]

Coverage remained the same at 91.429% when pulling 559a1d01755153b22b3ea223b1c77223a32e7455 on dthorne:master into 423c28021724cbf5ef9846a4adf500269de1bfa4 on visionmedia:master.

[drewswaycool]

This would be awesome and save some trouble in such cases.

[matthewp]

Thanks, but page.js is a generated file. Can you make the change in index.js instead?

[drewswaycool]

@matthewp If the change is made to index.js will the generated page.js reflect that change?

[paulocoghi]

@drewswaycool , yes it will reflect :)

[dthorne]

@matthewp Thanks for looking at this. I think it should be good now.

[drewswaycool]

@matthewp any updates?

[cecilia-sanare]

Here's a temporary workaround for anyone who's currently blocked by this issue.

// TODO: Remove this once v1.8.5 of page.js is released!
// Throw this before any page.js logic is invoked.
if (!('path' in Event.prototype)) {
  Object.defineProperty(Event.prototype, 'path', {
    get: function() {
      return this.composedPath ? this.composedPath() : [this.target];
    }
  });
}