visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

Contexts no longer work with hashbang enabled #504

Closed 43081j closed 5 years ago

43081j commented 5 years ago

https://github.com/visionmedia/page.js/blob/85e06e6fa65bc5c4e127bb71a91f1108302fe940/index.js#L652

I believe this should be _page._hashbang. It is always undefined so all contexts fail to produce the right path in hashbang mode.

This is since 1.10.0, 1.9.0 worked fine.

Tests should have picked this up, so it seems we are missing some crucial ones.

kaisermann commented 5 years ago

Hit this today and have opened a PR #505

matthewp commented 5 years ago

Closed by #505, thanks @kaisermann !