make sure _onpopstate is defined in non-browser envs

visionmedia / page.js

Micro client-side router inspired by the Express router

http://visionmedia.github.com/page.js

7.67k stars 687 forks source link

make sure _onpopstate is defined in non-browser envs #507

Closed flootr closed 5 years ago

flootr commented 5 years ago

fixes #501

coveralls commented 5 years ago

Coverage decreased (-1.3%) to 92.437% when pulling db2b615252898d2a32edf507c05e0b3c5ca8426a on flootr:fix/onpopstate into 02c026ca82f9d3f5018038d822592e77c040cfb7 on visionmedia:master.

matthewp commented 5 years ago

I really want to keep the test coverage up and not accept PRs that reduce it. If you are able to add a test which fixes this decrease that's great. Otherwise I'll get to it eventually. Thanks again for the PR!

flootr commented 5 years ago

@matthewp fair point, I'll see if I can get to it soon 👍

flootr commented 5 years ago

@matthewp I've a hard time creating tests for this. If you don't mind I'd appreciate if you would take this over.

matthewp commented 5 years ago

Let's just merge.