TypeScript: Missing default export

visionmedia / page.js

Micro client-side router inspired by the Express router

http://visionmedia.github.com/page.js

7.67k stars 687 forks source link

TypeScript: Missing default export #516

Closed rcroote closed 5 years ago

rcroote commented 5 years ago

We're using page.js for an internal project and ran across an issue with TypeScript.

From what I can figure out, rollup is not assigning globalPage as the default correctly. This works around that problem.

coveralls commented 5 years ago

Coverage decreased (-1.3%) to 92.437% when pulling 873d991ca81020db9c9974f1a87500aad45b3250 on rcroote:fix-typescript-default into 02c026ca82f9d3f5018038d822592e77c040cfb7 on visionmedia:master.

coveralls commented 5 years ago

Coverage remained the same at 92.017% when pulling 8a4ed073e7c6d4383ca37bbf3d7e35027cb89f9e on rcroote:fix-typescript-default into 08af410edbafe60a4c118ceea51608e68243fda5 on visionmedia:master.

matthewp commented 5 years ago

Can you rebase with master and run make again?

rcroote commented 5 years ago

Sure. All set.