search

visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

Save state for file:// protocol #529

Closed PaulMaly closed 5 years ago

PaulMaly commented 5 years ago

Hi! Could you please give me advise, how to save a state when file:// protocol used?

It seems, saving disable for this case, but I don't know which purpose of this. https://github.com/visionmedia/page.js/blob/bb44f10cb2e006b67645f2f37b4f889d7e2adffe/index.js#L711

Could you please explain why so? Thanks!

PaulMaly commented 5 years ago

@matthewp Any ides?

matthewp commented 5 years ago

Unfortunately not. I think we need to figure out a better way to test file:// though. It's been a continued pain and regressions occur. Did you try doing a git blame to see if that was added? Might be able to track down the issue.

PaulMaly commented 5 years ago

@matthewp Seems, it was added by you here: https://github.com/visionmedia/page.js/commit/12e018964703dfaafe6ef1a5806d84a78615f8f4

I just need to understand is it really needed?

UPDATE: Probably you reacted to this bug in Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=529313

But seems it's working now. I checked on my local html file and not seen any errors.

PaulMaly commented 5 years ago

I've submitted two patches for this issue:

https://github.com/visionmedia/page.js/pull/530 https://github.com/visionmedia/page.js/pull/531

Could you please check them and merge to the master?

PaulMaly commented 5 years ago

@matthewp Any news here? Sorry for my perseverance but it’s very important to me to stay in original repo.

matthewp commented 5 years ago

Yeah sorry for the delay, looking now..

matthewp commented 5 years ago

Ok, merged those two. Just looking to see if there are anything else to merge and then I'll do a release. Closing this issue since it's fixed.