search

visionmedia / page.js

Micro client-side router inspired by the Express router
http://visionmedia.github.com/page.js
7.67k stars 687 forks source link

fix ie11 sameOrigin check on https #547

Closed 5im-0n closed 4 years ago

5im-0n commented 4 years ago

On IE11 if the port is 80 or 443, url.port is empty, so we have to check if port is 443 in case of https too. Also, === got changed to ==, because url.port is a string on some versions of IE11 (tested on IE11 on Windows 7).

(I really hope I don't have to support this browser for much longer)

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 92.531% when pulling 78c3cb7d3ecc96dab9b1bb9b6fcd579c7f724c5d on S2-:fix-ie11 into 0d7e127037abd021fa299e2d8d0a4b727476712f on visionmedia:master.

chevett commented 4 years ago

you need to make this change to index.js then run npm run make to rebuild page.js

5im-0n commented 4 years ago

Thanks @chevett, I did, and I added a jshint ignore:line and documented the reason for the ==. When running npm run make to rebuild page.js I also noticed that there was one other unrelated change on line 1193: - delete params[0].