make the in browsers tests pass

visionmedia / page.js

Micro client-side router inspired by the Express router

http://visionmedia.github.com/page.js

7.67k stars 687 forks source link

make the in browsers tests pass #549

Closed chevett closed 4 years ago

chevett commented 4 years ago

Running npm run serve then visiting http://localhost:5000 results in all tests failing.

The problem is that test/index.html attempts to reference ../page.js. This is not allowed by serve.

However, there is already a symlink from the tests dir to page.js. So, if we allow serve to follow symlinks then the problem is resolved and all the tests pass.

coveralls commented 4 years ago

Coverage remained the same at 92.531% when pulling 8b17f67ebf0a9ef6433a58da41f02042b4dd6696 on relay-delivery:fix-browser-tests into 0d7e127037abd021fa299e2d8d0a4b727476712f on visionmedia:master.

matthewp commented 4 years ago

Awesome, thank you!