visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
428 stars 110 forks source link

Problems with lighting in point-type glyph plots #17257

Closed markcmiller86 closed 2 years ago

markcmiller86 commented 2 years ago

Describe the bug

This report captures a few issues related to lighting in point-type, glyph plots but a slightly different experience than reported in #17108

My experience reported here is on macOS 10.15.7 but I suspect the platform is unrelated.

To Reproduce

  1. Run visit -noconfig (thats mainly to rule out any odd-ball settings you might be starting with)
  2. Open noise.silo
  3. PC plot PointVar with PointType glyping and point size of 2 (those are the defaults VisIt ships with)
  4. Be sure that the Lighting checkbox of the PC plot attributes is checked.
  5. To increase the point cloud to something that can reveal behavior, apply a 3D reflect (with all 8 quadrants active) 3x.
  6. Apply Transform operator for coordinates from cylindrical to cartesian (its non-sensical as far as the data goes and I honestly don't know if it is at all related to the behavior but I was running in this modality to try to reproduce a user's report (#17108) and so was including this operator in my testing)
  7. Draw
  8. First, rotate the plot around and confirm that the lighting DOES NOT CHANGE as the view angle is changed.
  9. Go to Controls->Lighting...(it should be a camera type light with white color and 100% intensity aimed down the -Z axis.)
  10. ISSUE 1: Move the light source to a high off-angle position and hit apply. Observe no change in lighting in the plot. Rotate the plot as well to rule out that somehow lighting changed on surfaces facing a way from you.
  11. Reset the view and return the camera light to -Z axis position (or as close as you can) and hit apply.
  12. Switch to Object type light and hit apply. You should observe no change.
  13. ISSUE 2: Rotate the view. You should observe changes in lighting because now the light is moving with the object and you should see the lighting vary as the object moves through angles where the light is now facing your eye (like a sunset) and so no surfaces facing you are getting light. There is no change in lighting.
  14. Reset the view.
  15. Switch to am Ambient type light and reduce intensity to 0% and hit Apply. You should observe a change in lighting.
  16. ISSUE 3: Uncheck the Lighting checkbox in PC plot attributes. You should observe a change in lighting (I think you should. But, that depends on what it means for a PC plot to have Lighting unchecked. Maybe it means only to have the plot stop following whatever changes to lighting are being made and maintain only whatever the lighting was when it was UNchecked. In which case, this check box name is confusing).
  17. Repeat all the above with a different glyph type and confirm they behave correctly.
brugger1 commented 2 years ago

Closing this and will create a new more specific ticket.