Expressions are redone each time "apply" is clicked in the expressions window

[JustinPrivitera]

Describe the bug

Please see the attached file. It is the output of the "record" option in the "Command" window. I have added comments to explain what is going on. Essentially, it looks like hitting "apply" in the expressions window causes all of the default expressions to be redefined.

To Reproduce

Steps to reproduce the behavior. For example:

1. Open a file with visit
2. go to the command window and hit record
3. go to the expressions window
4. make a new expression
5. hit apply
6. stop the recording and examine results

Expected behavior

It doesn't seem like these expressions should be getting redefined. In the file I attached, they are defined twice just during the recording, while they should already be there at the start, when I open the file.

Attachments

• Can you reproduce the bug on our test data?
  • I've done this using testdata/silo_hdf5_test_data/multi_ucd3d.silo

Desktop

• OS and version: rztopaz
• VisIt Version: 3.2RC and Develop

Additional context

Add any other context about the problem here. Attach any (zipped) relevant files, such as data, configurations, sessionfiles, etc. record_bug.txt

[markcmiller86]

@JustinPrivitera honestly something silly like this doesn't necessarily surprise me.

IMHO, there is a lot of complexity in the GUI and in how expressions are managed that could be improved substantially.

During opens, I think we wind up re-populating GUI widgets 2 or 3 times before the open is completed!

We are also still suspect of some possible race conditions in the GUI during opens.

[brugger1]

We shouldn't be recording database or automatic expressions.

[JustinPrivitera]

:(