search

visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
435 stars 114 forks source link

Begin HDF4 plugin retirements by disabling in builds #18059

Closed markcmiller86 closed 2 years ago

markcmiller86 commented 2 years ago

It looks like nobody is using HDF4 plugins and we are free to retire them.

@biagas had the great idea of simply disabling them in new builds with the goal of eventually removing them entirely. For now, this can be achieved by disabling the --hdf4 option in build_visit and removing refs to hdf4 plugins in src/databases/CMakeLists.txt

Here is a list of effected files many of which will ulimately be removed.

% pwd
/Users/miller86/visit/visit/src
% find . -type f -exec grep -q -i hdf4 {} \; -print
./databases/CMakeLists.txt
./databases/Enzo/
./databases/Cosmos/
./databases/ZeusMP/
./databases/RAGE/
./tools/dev/masonry/opts/mb-3.1.0-darwin-10.13-x86_64-release.json (make sure newest masonry won't use HDF4)
./tools/dev/scripts/bv_support/helper_funcs.sh
./tools/dev/scripts/bv_support/bv_hdf4.sh
./tools/dev/scripts/bv_support/modules.xml
./CMakeLists.txt
./CMake/PluginVsInstall.cmake.in
./CMake/FindHDF4.cmake
./include/visit-cmake.h.in
./config-site/cooleylogin2.cmake
./config-site/shark23.cmake
./config-site/seqlac3-compute.cmake
./config-site/scratlantis.cmake
./config-site/ubuntu1404-64.sqalab-llnl.gov.cmake
./config-site/coruscant.cmake
./config-site/cori08.cmake
./config-site/kickit.llnl.gov.cmake
./config-site/wortchiller.sci.utah.edu.cmake
./config-site/quartz1922.cmake
./config-site/jade188.cmake
./config-site/whoopingcough.cmake
./config-site/beetlehunter.cmake
./config-site/ash1.cmake
./config-site/justin-IdeaPad-L340-17IRH-Gaming.cmake
./config-site/rzuseqlac2-compute.cmake
./config-site/sierra4358.cmake
./config-site/ironhide.cmake
./config-site/vulcanlac4-compute.cmake
./config-site/seqlac3-login.cmake
./config-site/blackrock_client.engr.utk.edu.cmake
./config-site/zin497.cmake
./config-site/spencer.cmake
./config-site/UL329899-testing.cmake
./config-site/UL329899.cmake
./config-site/windows.cmake
./config-site/carver.nersc.gov.cmake
./config-site/convertconfigs.py
./config-site/tr-fe1.cmake
./config-site/cori.nersc.gov.cmake
./config-site/vulcanlac4-login.cmake
./config-site/lassen708.cmake
./config-site/optimusprime.local.cmake
./config-site/floyd.llnl.gov.cmake
./config-site/quartz386.cmake
./config-site/rodimusprime-icc.cmake
./config-site/kickit.mesagl.cmake
./config-site/nostril.cmake
./config-site/ember1.cmake
./config-site/rzuseqlac2-login.cmake
./config-site/unibrow.cmake
./config-site/updraft1.cmake
./config-site/bart.lbl.gov.cmake
./config-site/ion.cmake
./config-site/rhea.cmake
./config-site/rzansel61.cmake
./config-site/ifyou.cmake
./config-site/bumblebee.cmake
./config-site/cyclonus.llnl.gov.cmake
./config-site/ferment.sci.utah.edu.cmake
./config-site/rztopaz194.cmake
./config-site/login1.cmake
./config-site/whitney.cmake
./config-site/winnipeg.llnl.gov.cmake
./config-site/rodimusprime.cmake
./config-site/thembisa.llnl.gov.cmake
./config-site/blackrock.engr.utk.edu.cmake
./config-site/warpath.cmake
./config-site/ubuntu1104-64.sqalab-llnl.gov.cmake
./config-site/rhea.ccs.ornl.gov.cmake
brugger1 commented 2 years ago

For 3.3.1 we can just disable --hdf4 in build_visit. The actual removal of the code can happen in 3.4.0.