search

visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
437 stars 116 forks source link

qt6 needs a patch to build qwt with XCode 15 #19414

Closed BenWibking closed 5 days ago

BenWibking commented 7 months ago

Describe the bug

qt6 does not build with XCode 15 due to this bug: https://bugreports.qt.io/browse/QTBUG-117225

It can be fixed with this patch: https://codereview.qt-project.org/changes/qt%2Fqtbase~503172/revisions/3/patch?zip&path=mkspecs%2Ffeatures%2Ftoolchain.prf

Desktop

Additional context

Without this patch, the build_visit --qt6 fails at the qwt build on macOS 14:

Building Qwt (~3 minutes)
prepare_build_dir: qwt-6.3.0 qwt-git-d3706f6e7f0351d278be2d989a4caaf92b399bbd.tar.xz
Unzipping/Untarring qwt-git-d3706f6e7f0351d278be2d989a4caaf92b399bbd.tar.xz . . .
Patching Qwt . . .
patching file qwtconfig.pri
Info: creating stash file /Users/benwibking/visit/src/tools/dev/scripts/qwt-6.3.0/.qmake.stash
Project ERROR: failed to parse default search paths from compiler output
BenWibking commented 6 months ago

For future reference, the steps to patch are:

$  build_visit cd qtbase-everywhere-src-6.4.2
$  qtbase-everywhere-src-6.4.2 patch -p1 < cdf64b0.diff

cdf64b0.diff.zip

cyrush commented 6 months ago

@BenWibking thanks for this patch, we will look into incorporating it for Visit 3.4.2

cyrush commented 5 days ago

Resolved for 3.4.2 on 3.4RC with #19976 Resolved on develop with #19979