search

visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
438 stars 116 forks source link

Add cmake-packages support #19592

Open Febbe opened 5 months ago

Febbe commented 5 months ago

Is your feature request related to a problem?

The library is build and installed with cmake, but there is no way to include it in a cmake project after installation.

Describe the solution you'd like.

The project should also create cmake config files.

Describe alternatives you've considered.

Additional context

https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-packages https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html https://cmake.org/cmake/help/latest/command/find_package.html#command:find_package

biagas commented 5 months ago

I am currently in the process of updating VisIt's CMake usage to create cmake config files. VisIt is a very large and complex project with many dependencies, so this effort will take a bit of time to be fully functional.

Can you describe exactly what you are attempting to do with VisIt and why you need the cmake config files?

Febbe commented 5 months ago

I recently assisted a colleague in adding a visit to his project. He had been doing it manually and encountered issues with linking on Windows when mixing different runtimes. I wondered why he wasn't using the configuration files from the installation. It turns out those files weren't generated. It would be beneficial to provide these files through CI, so we wouldn't have to add them manually. Having those config files would simplify a lot.