HAVE_QWT double defined compile warning

visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data

https://visit.llnl.gov

BSD 3-Clause "New" or "Revised" License

428 stars 110 forks source link

HAVE_QWT double defined compile warning #19766

Open cyrush opened 3 weeks ago

cyrush commented 3 weeks ago

Describe the bug

Looks like it is in visit-config.h, and is also being used on the compile command line:

:9: warning: 'HAVE_QWT' macro redefined [-Wmacro-redefined]
#define HAVE_QWT 
        ^
<command line>:2:9: note: previous definition is here
#define HAVE_QWT 1
        ^

visit-config.h is the right place, we can remove it from the command line.

But it has different values in each place (just defined vs defined as 1)

biagas commented 3 weeks ago

I had originally added it to gui/CMakeLists.txt as a COMPILE_DEFINITION.

Then thought it should also be in visit-config.h for either pluginVsInstall or simulations. However, I don't think simulations want to use visit-config.h because some of our definitions might collide. That's why Mark moved the version macros to their own header. So is the right place a different header, or only the compile definition?