visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
444 stars 117 forks source link

Remove use of HAVE_SNPRINTF #19913

Closed biagas closed 1 month ago

biagas commented 1 month ago

It was being used with scripting libraries to prevent python from #defining snprintf as _snprintf. This is no longer necessary with the python version we are currently using on Windows.

Modified GenerateCMake.h, and regenerated plots/operators CMakeLists.txt

Type of change

How Has This Been Tested?

Compiled and ran regression on windows sucessfully.

Checklist:

markcmiller86 commented 1 month ago

@biagas will have to wait til tomorrow. Still recovering from tooth 🦷 implant 🪛

markcmiller86 commented 1 month ago

Working on this now.

markcmiller86 commented 1 month ago

Ok, so it looks like this amounted to just removing some lines of logic to a bunch of CMakeLists.txt files that wound up defining HAVE_SNPRINTF for certain cases. I searched for *."[Ch]" and greped for any instances of SNPRINTF and didn't find any others.