search

visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
444 stars 117 forks source link

Onion Peel Domain Selection should be a typeable field instead of a drop down menu #19920

Closed JustinPrivitera closed 1 month ago

JustinPrivitera commented 1 month ago

A user on teams suggested our onion peel operator ought to let you type the domain number instead of using a drop down list to choose domain.

https://teams.microsoft.com/l/message/19:f2ed7be3682d40d1b8e038744e500a09@thread.skype/1729293032152?tenantId=a722dec9-ae4e-4ae3-9d75-fd66e2680a63&groupId=70162982-9587-4bcc-ad53-20178c76fe11&parentMessageId=1729292943233&teamName=VisIt&channelName=General&createdTime=1729293032152

Please have onion peel domain number be typeable instead of a drop down. I've never understood this choice, at least in ALE you can have hundreds of domains.

biagas commented 1 month ago

Would have to edit QvisSILSelector.C, make the subsetName QComboBox editable with a NoInsert policy. Probably should utilize a Completer and/or Validator as well. https://doc.qt.io/qt-6/qcombobox.html

JustinPrivitera commented 1 month ago

Is there an issue with the domain names not being uniform? i.e. sometimes it is processor and sometimes it is domain?

biagas commented 1 month ago

Shouldn't be a problem. The window uses the set names as contained in the SIL to fill in the list. The Completer can be filled with the same list. Haven't looked into usage of a Validator yet.