The internallauncher script uses offload-arch to determine the AMD GPU architecture. Unfortunately this utility can exist on non-AMD systems and cores when run on them. I added additional logic to prevent the script from running offload-arch on non-AMD systems.
I didn't update the release notes since this feature was just added and has not been in a release.
Type of change
[X] Bug fix~~
How Has This Been Tested?
I built and installed VisIt on poodle, which is a non-AMD system. I ran VisIt from the installation and verified that it properly identified the system type and didn't produce any core files. The system type in this case was linux-x86_64.
I built and installed VisIt on rzvernal, which is an AMD system with MI250X GPUs. I ran VisIt from the installation and verified that it properly identified the system type and didn't produce any core files. The system type in this case was linux-x86_64-gfx90a.
Merge from the 3.4RC to develop.
Description
Resolves #19992
The
internallauncherscript usesoffload-archto determine the AMD GPU architecture. Unfortunately this utility can exist on non-AMD systems and cores when run on them. I added additional logic to prevent the script from runningoffload-archon non-AMD systems.I didn't update the release notes since this feature was just added and has not been in a release.
Type of change
How Has This Been Tested?
I built and installed VisIt on
poodle, which is a non-AMD system. I ran VisIt from the installation and verified that it properly identified the system type and didn't produce any core files. The system type in this case waslinux-x86_64.I built and installed VisIt on
rzvernal, which is an AMD system with MI250X GPUs. I ran VisIt from the installation and verified that it properly identified the system type and didn't produce any core files. The system type in this case waslinux-x86_64-gfx90a.Reminders:
Checklist:
[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.