visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
443 stars 116 forks source link

Displace Filter lets variables through without a dimension check #20017

Closed JustinPrivitera closed 2 weeks ago

JustinPrivitera commented 2 weeks ago

Description

Resolves #19719

Mili DB provides an expression called displacement. There is no way for VisIt to know the dimension of the expression until it is asked to use it. The displace operator asks for the dimension before it uses the variable, so VisIt fails to correctly identify the dimension and defaults to 1, which is wrong. If you make a vector plot of displacement before using it in the displace operator, it works fine, probably because VisIt is caching it somewhere. The solution we came up with is to ignore checks for variable dimension. Displacement should still fail if you give it something that doesn't make sense. The error message is much less informative but there is no other way to let expression variables through.

Type of change

How Has This Been Tested?

built and ran on rzhound toss4 all new and old tests pass

Reminders:

Checklist:

JustinPrivitera commented 2 weeks ago

merge w/ develop in #20019