Open biagas opened 1 week ago
Do we have tests for logging?
I haven't a clue at the moment how this could be accomplished.
Do we have tests for logging?
I haven't a clue at the moment how this could be accomplished.
I didn't think about it for more than a second, but yes, I also haven't a clue how this would be done. Nevermind.
Description
Resolves #19764 , #17395, #2681, #839.
I added
_ToString
methods to all of the Annotation object types that can be called from Logging.C. Modified the objects'str
andprint
methods to utilize_ToString
in order to reduce code duplication an prevent maintenance issues when fields are added/removed.Implemented logging for
AddAnnotationObjectRPC
,DeleteActiveAnnotationObjectsRPC
,HideActiveAnnotationObjectsRPC
andSetAnnotationObjectOptionsRPC
.Commented-out entries for
RaiseActiveAnnotationObjectsRPC
andLowerActiveAnnotationObjectsRPC
since those seem only useful inside the gui.I wasn't sure if this could go on RC, so haven't yet updated release notes, pending verification of version.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
I turned on logging and verified fields and values were accurated.
here are the results:
Checklist:
[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to [protocol or public interfaces][3] in an RC branch.