visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
440 stars 116 forks source link

Add logging for Annotation objects. #20028

Open biagas opened 1 week ago

biagas commented 1 week ago

Description

Resolves #19764 , #17395, #2681, #839.

I added _ToString methods to all of the Annotation object types that can be called from Logging.C. Modified the objects' str and print methods to utilize _ToString in order to reduce code duplication an prevent maintenance issues when fields are added/removed.

Implemented logging for AddAnnotationObjectRPC, DeleteActiveAnnotationObjectsRPC, HideActiveAnnotationObjectsRPC and SetAnnotationObjectOptionsRPC.

Commented-out entries for RaiseActiveAnnotationObjectsRPC and LowerActiveAnnotationObjectsRPC since those seem only useful inside the gui.

I wasn't sure if this could go on RC, so haven't yet updated release notes, pending verification of version.

Type of change

How Has This Been Tested?

I turned on logging and verified fields and values were accurated.

here are the results:

LegendObjectLogging ImageObjectLogging Text2DObjectLogging Text3DObjectLogging Line3DObjectLogging Line2DObjectLogging TimeSliderObjectLogging HideShowDeleteLogging

Checklist:

biagas commented 1 week ago

Do we have tests for logging?

I haven't a clue at the moment how this could be accomplished.

JustinPrivitera commented 1 week ago

Do we have tests for logging?

I haven't a clue at the moment how this could be accomplished.

I didn't think about it for more than a second, but yes, I also haven't a clue how this would be done. Nevermind.