visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
440 stars 116 forks source link

Fix Silo PBC indexing bug #20035

Closed markcmiller86 closed 3 days ago

markcmiller86 commented 1 week ago

Describe the bug

The new logic to support a mesh completely surrounded by periodic boundaries (PBCs) has a bug in it which is reproducible with the original dataset doing a contour plot of den variable.

markcmiller86 commented 3 days ago

Ok, I discovered I was not correctly handling the multimesh-adjacency object's back pointers properly after removing periodic domain neighbors. I have a working solution now but need to clean it up a bit. The logic is a tad complicated and I introduced a number of functions to help confirm the data structures were being kept consistent, both what is being read off disk from data file and what is modified in memory in plugin.

markcmiller86 commented 3 days ago

Resolved in #20054