visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
440 stars 116 forks source link

Fix Silo PBC logic #20052

Closed markcmiller86 closed 3 days ago

markcmiller86 commented 3 days ago

Description

Resolves #20035

Still needs cleanup. I just wanted to get the working solution pushed.

Type of change

How Has This Been Tested?

Tested with material and contour plots on original dataset from @cyrush

Reminders:

Checklist:

markcmiller86 commented 3 days ago

I am running some of the plot's (Pseudocolor, Contour, FilledBoundary) through valgrind to ensure I haven't introduced any other funkiness to behavior. @cyrush if you have other suggestions for further testing, lemme know.

markcmiller86 commented 3 days ago

Ok, I've run Psuedocolor, FilledBoundary, and Contour with MPI+valgrind and got no errors! I am seeing leaks though but I suspect that has to do with the fact that the engine generally doesn't try to clean up after itself when exiting. I will confirm that though.