Silo patching failing in build_visit

[biagas]

Describe the bug

The patches for fpzip are failing in container builds on Debian and Ubuntu, due to different line endings. I tried to force the cray path, which calls dos2unix, and uses a different patch function, but the dos2unix command wasn't available.

Desktop

• OS and version: Ubuntu, Debian
• VisIt Version: 3.4.2
• Server info (if applicable):

@markcmiller86 @JustinPrivitera suggestions?

[JustinPrivitera]

patch --binary perhaps?

[JustinPrivitera]

or maybe we just provide a good tarball with correct line endings

[biagas]

patch --binary perhaps?

didn't work.

or maybe we just provide a good tarball with correct line endings

I tried this manually, and it works. Had to also modify the build script to use the non-windows-line-endings version of the patch.

[JustinPrivitera]

well so, does it work if we modify the logic such that dos2unix is never called but the non-windows-line-endings patch is applied?

[biagas]

well so, does it work if we modify the logic such that dos2unix is never called but the non-windows-line-endings patch is applied?

No. Tried that first. Then I untarred the silo file, changed the fpzip files to unix style by hand, and retarred it. Modified the script, then reran and it worked.

[biagas]

BTW, I did try to install 'dos2unix' in the Debian container. Even thought their packages website shows it is available, I couldn't get it installed.

[biagas]

@markcmiller86 what do you think of modifying the silo source tarball used by build_visit to remove those pesky windows line endings?

[JustinPrivitera]

@cyrush says we can go ahead and modify the tarball.

[JustinPrivitera]

I will do this now.

[JustinPrivitera]

In TPL release and repo: