visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
438 stars 116 forks source link

OSPRay not producing shadows. #3480

Open BradWhitlock opened 5 years ago

BradWhitlock commented 5 years ago

Describe the bug

I ran VisIt 3.0.0 on Mac using Kevin's new OSPRay-enabled version. I can turn on OSPRay but little to nothing is different when I render. I can see that when OSPRay is enabled, the bounding box changes to shaded tubes. The overall picture quality is no better though. I see that OSPRay settings in the Rendering window have a "Shadows" check box. This setting appears to do nothing.

I made a script that does an isosurface and adds another plot to serve as a ground plane. When I use normal SR mode plus shadows, I get shadows cast. I do not get that when I run using OSPRay, plus the image looks no better.

I also noticed that the first image's depth buffer is saved out to a separate file though pixel data is set to 1 in the SetSaveAttributes. I think that pixelData == 1 means just save ColorRGB (see SaveWindowAttributes.h). This is a bug too.

Helpful additional information (Please click check boxes AFTER submitting ticket)

Impact

Likelihood

To Reproduce

Steps to reproduce the behavior:

  1. Unzip the attached zip file to get the ospray.py script
  2. visit -cli -nowin -noconfig -s ospray.py
  3. Look at the resulting visit????.png files. The first one is for SR mode. The second one is for OSPRay and it is not as good as the SR mode version.

Expected behavior

I expected that when I select OSPRay rendering that I would get better shadows than I would get in SR mode. I also expected some ray traced appearance (reflections, etc). Without those, I see no upside to OSPRay.

Attachments

Desktop

Additional context

N/A

cyrush commented 5 years ago

@BradWhitlock there is some strange multi-layer initialization bug. If you enable ospray w/ shadows, nothing seems to happen until you actually move a light. If you turn it off an on again you still have the same type of issue.