visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
437 stars 116 forks source link

pyqt and mdsplus appear non functional in build_visit. #3944

Open brugger1 opened 5 years ago

brugger1 commented 5 years ago

Describe the bug

I was updating the remaining checksums for the source code files for build_visit and noticed that bv_pyqt.sh and bv_mdsplus.sh were non-functional.

The pyqt module looked incomplete and the source code for the mdsplus module is unavailable (not in VisIt repo and no URL specified).

I found the MDSplus project web site. It is a set of tools for scientific data. They have the code on GitHub, but I couldn’t find anything even close to a 5.0 release, so what we have must be really old.

http://www.mdsplus.org/index.php?title=Introduction&open=6913025428015808529&page=Introduction https://github.com/MDSplus/mdsplus

I have submitted an issue with them on GitHub, asking if they know anything about our reader.

Impact

Likelihood

brugger1 commented 5 years ago

Here is the response I got from Josh Stillerman, one of the MDSplus developers about the VisIt reader and using their library.

The visit MDSplus reader should be using our standard APIs which have not changed. The best way for this to be distributed is to either have the directions say to install our platform specific kits, or include the shareable libraries installed from our kits. Regardless, since visit can call into (or link against) the shared libraries the MDSplus sources should not be relevant.

brugger1 commented 4 years ago

Let's remove pyqt and leave MDSplus broken until someone reports an issue.

brugger1 commented 1 year ago

We can safely remove both of those from build_visit. We should leave the MDSplus reader.