visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
427 stars 109 forks source link

Add patch to build_visit for llvm with llvm-5.0.0. #4062

Closed brugger1 closed 4 years ago

brugger1 commented 4 years ago

Describe the bug

A user reported build_visit failing with llvm using Intel 2019.5.

Impact

Likelihood

Attachments

Here is the e-mail exchange with the error, which should provide the information required to make the patch.

Hi Andy,

I think the simplest fix is to just remove or comment out that line since it is just an assert and isn't critical to the software working properly. I will add a patch that removes that line to build_visit for either 3.1.0 or 3.1.1.

Eric

-----Original Message----- From: Andrew Wood via visit-users visit-users@elist.ornl.gov Sent: Friday, November 15, 2019 8:29 AM To: visit-users@ornl.gov Cc: Andrew Wood andrew@fluidgravity.co.uk Subject: [visit-users] [EXTERNAL] Building VisIt 3.0.2 with Intel 2019.5

I'm trying to build VisIt 3.0.2 with the Intel 2019.5, but I get the following error when the build script builds llvm-5.0.0:

/home/andrew/visit_build_scripts/3.0.2/llvm-5.0.0.src/lib/IR/Attributes.cpp(813): error: expression must have a constant value static_assert(attrIdxToArrayIdx(AttributeList::FunctionIndex) == 0U, ^ /home/andrew/visit_build_scripts/3.0.2/llvm-5.0.0.src/lib/IR/Attributes.cpp(798): note: value exceeds range of "int" return static_cast(Index) + 1; ^ compilation aborted for /home/andrew/visit_build_scripts/3.0.2/llvm-5.0.0.src/lib/IR/Attributes.cpp (code 2)

Can anyone advise how to fix this?

Thanks, Andy.

-- Dr Andrew Wood Fluid Gravity Engineering Ltd. 83 Market Street St Andrews Fife KY16 9NX Tel: +44 (0)1334 460805 Fax: +44 (0)1334 460813

Fluid Gravity Engineering Ltd is registered in the UK with registration number 1674369. The registered address is Fluid Gravity Engineering Ltd, Unit 1, The Old Coach House, 1 West Street, Emsworth, Hampshire, PO10 7DX.

Desktop

brugger1 commented 4 years ago

We should look and see if this is a C++ 11 feature or something that llvm has defined. Also, does it get compiled out with optimization.