visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
434 stars 111 forks source link

GetQueryParameters("Pick") returns None #5431

Open markcmiller86 opened 3 years ago

markcmiller86 commented 3 years ago

Describe the bug

I wanted to see example of parameter set for doing Query("Pick") and learned about two great CLI methods in this section of the CLI manual; Queries() which returns a list of all the query names and GetQueryParameters(qname) which apparently returns the dictionary needed for a given query. For "Pick" it returns None. I assume that is not intended.

Helpful additional information

To Reproduce

This is what I was doing...

./bin/visit -cli -o silo_hdf5_test_data/curv3d.silo
>>> Queries()
('Eulerian', 'Compactness', 'Cycle', 'Time', 'L2Norm', 'Kurtosis', 'Chord Length Distribution - individual', 'Chord Length
 Distribution - aggregate', 'Ray Length Distribution - individual', 'Ray Length Distribution - aggregate', 'Mass Distribution', 
'Distance From Boundary', 'Line Scan Transform', 'Hohlraum Flux', 'Skewness', 'Integrate', 'Expected Value', 'L2Norm 
Between Curves', 'Area Between Curves', 'Revolved volume', 'Revolved surface area', '2D area', '3D surface area', 'Volume', 
'Volume2', 'Total Length', 'Moment of Inertia', 'Centroid', 'Localized Compactness Factor', 'Elliptical Compactness Factor', 
'Spherical Compactness Factor', 'Average Mean Curvature', 'Average Value', 'Variable Sum', 'Watertight', 'Weighted Variable 
Sum', 'Number of Connected Components', 'Connected Component Length', 'Connected Component Area', 'Connected 
Component Centroids', 'Connected Component Volume', 'Connected Component Variable Sum', 'Connected Component 
Weighted Variable Sum', 'Connected Components Summary', 'Shapelet Decomposition', 'XRay Image', 'Python', 'GyRadius', 
'MinMax', 'Min', 'Max', 'SpatialExtents', 'NumNodes', 'NumZones', 'Grid Information', 'Zone Center', 'Node Coords', 
'TrajectoryByZone', 'TrajectoryByNode', 'Best Fit Line', 'Memory Usage', 'Sample Statistics', 'Population Statistics', 'Integral 
Curve Info', 'Line Sampler Info')
>>> GetQueryParameters("Pick")
>>> 

Expected behavior

A python dictionary of values for the named query, "Pick"

Was running 3.1RC on macOS

rusu24edward commented 3 years ago

Related to #5421

markcmiller86 commented 3 years ago

The Pick query is a bit of an oddball because that operation existed as its own special thing (a pick operation) before queries were created. So, even though it is treated kinda sorta like a query, its really its own special operation and there is special logic to handle it as a query in the GUI. The GUI does indeed list Pick as one of the possible options but note, in the list output by Queries() above, 'Pick' actually does not appear.

So, if we continue to treat Pick as a query, we should probably add logic here so that it is treatable that way in all respects. Alternatively, we could create a new GetPickParameters() method for pick.