visit-dav / visit

VisIt - Visualization and Data Analysis for Mesh-based Scientific Data
https://visit.llnl.gov
BSD 3-Clause "New" or "Revised" License
434 stars 112 forks source link

MACOSX_BUNDLE_COPYRIGHT defined in multiple places, not all of which are up-to-date #5935

Open biagas opened 3 years ago

biagas commented 3 years ago

Describe the bug

Here are the multiple places of definition: https://github.com/visit-dav/visit/blob/9efab8b6af8c084cb4cfa2c2de4dd9fedee09b39/src/viewer/main/CMakeLists.txt#L256 https://github.com/visit-dav/visit/blob/9efab8b6af8c084cb4cfa2c2de4dd9fedee09b39/src/tools/examples/mcurvit/CMakeLists.txt#L96 https://github.com/visit-dav/visit/blob/9efab8b6af8c084cb4cfa2c2de4dd9fedee09b39/src/tools/examples/embedviewer/CMakeLists.txt#L87 https://github.com/visit-dav/visit/blob/9efab8b6af8c084cb4cfa2c2de4dd9fedee09b39/src/tools/dev/xmledit/CMakeLists.txt#L64 https://github.com/visit-dav/visit/blob/9efab8b6af8c084cb4cfa2c2de4dd9fedee09b39/src/gui/main/CMakeLists.txt#L71

For maintenance reasons, I'm wondering if this could/should be defined at our root CMakeLists.txt?

If it actually needs to be set in each of the individual CMakeLists.txt, then perhaps define the following in root CMakeLists.txt

set(VISIT_MACOSX_BUNDLE_COPYRIGHT "Copyright (c) 2000 - 2021, Lawrence Livermore National Security, LLC") and then change all references to: set(MACOSX_BUNDLE_COPYRIGHT ${VISIT_MACOSX_BUNDLE_COPYRIGHT})

Desktop

brugger1 commented 3 years ago

This could be done in root CMakeLists.txt file.