search

visitscotland / dot-com-brxm

MIT License
0 stars 0 forks source link

(FED) Video playback issues on Peebles page #226

Open shenderson4 opened 1 year ago

shenderson4 commented 1 year ago

Describe the bug

The 'Welcome to the Tweed Valley' video on the Peebles page is displaying differently for different users. For some, when clicked, it enlarges and the video plays fine, but the exit button doesn’t work. Runtime and play icons are also missing from the thumbnail.

Another user reports the scenario that after watching the Step into the Scottish Borders video which played as expected, then clicking on Tweed Valley video, the SitSB video opens again and doesn't respond - it doesn't play and won't close.

The video also features on https://www.visitscotland.com/places-to-go/scottish-borders but works as expected.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.visitscotland.com/places-to-go/peebles
  2. Click on the 'Welcome to the Tweed Valley' video
  3. See error of no thumbnails
  4. Open video and play
  5. See if one of the errors described above appears (no close option, or playing wrong video)

Expected behavior

Video should display thumbnails and play the correct video with options of closing the video

Page URL

URL of page where the bug exists

Environment

Hippo Live CMS

Browser

Chrome

Device and version

If applicable, device the bug was seen on

Impact on end user

Unable to navigate video options or display correct video

Impact on product development

Additional context

Raised by Hayley Wilkins and Helene Sinclair that Go Tweed Valley have made a complaint about this.

Image

Image

Potentially related to #289

MichaelGrahamVS commented 1 year ago

Hi @GemmaLouise can you take a look at this next Sprint please? External partners are asking for an update.

MichaelGrahamVS commented 1 year ago

@GemmaLouise forgot to bring this one up in backlog refinement. Would be good if we could at least diagnose what the issue is for this Sprint considering there is external pressure. Let me know if that is feasible.

GemmaLouise commented 1 year ago

@MichaelG-PO @MairiScobie Not sure but think it could be a content issue as they have a duplicate video - the video "Step into the Scottish Borders" is appearing twice on the page, I assume "Welcome to Tweed Valley" is meant to be a different video?

MairiScobie commented 1 year ago

@MichaelG-PO @GemmaLouise Hello! Just had a look within the CMS and the video link is correct (linking to this video - https://www.youtube.com/watch?v=fdNECZ1tZMM) so not sure why the Step into the Scottish Borders is appearing for both videos on the Peebles page. It also doesn't let you close or click off the video either.

GemmaLouise commented 1 year ago

@MichaelG-PO @MairiScobie Yeah this is weird, seems to be an issue when you have 2 or more videos in a Megalinks, the last video added seems to overwrite the others. Will take a look at it, thanks.

GemmaLouise commented 1 year ago

@MichaelG-PO @MairiScobie Have had a further look into this and found it isn't the video causing the issue but the modal component. It works for us in Storybook and locally but break with SSR - assuming this is related to the update from Vue 2 to Vue 3. Unfortunately, I'm not getting any errors or clues as to why its breaking and cant seem to find a quick fix.

For now we may want to avoid putting more than 1 video on the page until we have a fix which may be that we need to build a new modal component that works with our SSR app.

MichaelGrahamVS commented 1 year ago

Hi @MairiScobie to fix this issue we may need to redevelop our modal component, which is going to take some time. A workaround for the moment (appreciate it's far from ideal) is to only have one video per page. On the Peebles page, can we remove the Scottish borders video and just have the Tweed Valley video instead as I believe this is the one the partner wanted?

cc @nikkisherret @GemmaLouise

MairiScobie commented 1 year ago

Hi @MairiScobie to fix this issue we may need to redevelop our modal component, which is going to take some time. A workaround for the moment (appreciate it's far from ideal) is to only have one video per page. On the Peebles page, can we remove the Scottish borders video and just have the Tweed Valley video instead as I believe this is the one the partner wanted?

cc @nikkisherret @GemmaLouise

@MichaelG-PO Thanks Michael, I'll action this now.

MichaelGrahamVS commented 1 year ago

Thanks, @MairiScobie !

mjpvs commented 12 months ago

Hey @CorinaMala, this one should be good to test now

https://feature.visitscotland.com/?vs_brxm_host=172.28.87.25&vs_brxm_port=8010&vs_brxm_http_host=feature.visitscotland.com&vs_ssr_http_port=8210&vs_tln_http_port=8310&vs_feature_branch=PR-341&vs_ssr_proxy=on

https://feature.visitscotland.com/test/modules/megalinks/megalinks-multi-image

The megalink module on that page now has 2 videos in it. Previously, it was failing to render two separate modals, so the second one would work as expected and the first one would fail, it would get no play button and if you clicked it it would open the modal for the second one, displaying the wrong video and not autoplaying it. Now they should both get play buttons as expected (assuming you've accepted cookies) and they should both play the expected video in the popup

image

CorinaMala commented 11 months ago

Hi @mjpvs that's this issue tested on the feature-env mentioned. The two videos are now working as they should, not showing a different video/thumbnail. Ready to be merged to develop