search

visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

(FED) Blank spaces appearing when there is no data to display #113

Closed KirstyScott closed 1 week ago

KirstyScott commented 1 year ago

Blank spaces appearing when there is no data to display - as an example, in the module wrapper there is a gap between the map and heading (too big if there’s no description text), on all mobile platforms.

Environment url: [https://feature.visitscotland.com/?vs_brxm_host=172.28.87.25&vs_brxm_port=8030&vs_brxm_http_host=feature.visitscotland.com&vs_ssr_http_port=8230&vs_tln_http_port=8330&vs_feature_branch=PR-56&vs_ssr_proxy=on]

[https://feature.visitscotland.com/test/examples/outlander]

Image

More Information It looks like the way we are checking if slots have content in the component is not working anymore in Freemarker so this will be an issue across the site where we are checking for empty slots

KirstyScott commented 1 year ago

VSD-577

MichaelGrahamVS commented 1 year ago

Still an issue. For e.g. see https://www.visitscotland.com/places-to-go/dunfermline space under Dunfermline heading