search

visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

213 fed update map pin hoverfocus states to be consistent across maps #259

Closed GemmaLouise closed 10 months ago

GemmaLouise commented 10 months ago

For testing build env only

mjpvs commented 10 months ago

@GemmaLouise is this one all code that has been reviewed in other PRs (like this one https://github.com/visitscotland/vs-component-library/pull/258 ?), I'm losing track a bit of the maps branches

GemmaLouise commented 10 months ago

@GemmaLouise is this one all code that has been reviewed in other PRs (like this one #258 ?), I'm losing track a bit of the maps branches

I only created this PR to main for a testing env as the ones to the main map branch dont build a storybook env (noted at the top). So I created a separate PR to the main map branch for easier code review and added you there.

This will be the last of the map tickets and once this release is done and this has been tested ill get it all merged to main and do a minor release to integrate into .com.