visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

(FED) Maps - Filter button not opening filter menu #309

Closed KirstyScott closed 6 months ago

KirstyScott commented 6 months ago

Raised by

Who raised the bug

Describe the bug

When a user selects the filter button, after they have opened and closed a destination from a pin on the map, the filter menu will not open and instead the pin they had previously selected will display.

Image

To Reproduce

Steps to reproduce the behavior:

  1. Go to [(https://www.visitscotland.com/places-to-go)](https://www.visitscotland.com/places-to-go) on mobile.
  2. Click on a map pin and then exit out of it. Click on the filter menu.
  3. Previous pin will open up instead of filter menu.

Expected behavior

Ensure the filter menu displays when the user selects this at any time in their journey.

Image

Page URL

https://www.visitscotland.com/places-to-go

Environment

Live

Browser

All

Device and version

If applicable, device the bug was seen on

Impact on end user

Frustrating user journey

Impact on product development

Additional context

Add any other context about the problem here.

MichaelGrahamVS commented 6 months ago

@duncansanderson to catch up with @annacardellini & @aislingwalsh to finalise fix for this issue.

duncansanderson commented 6 months ago

Hey @CorinaMala, I've updated the map with sidebar component to fix this issue. This fix also fixes the issue in #310.

You can test the fix here: https://646df3398f07e38a95184dbb-spkicnabqe.chromatic.com/?path=/story/mapwithsidebar--outlander

CorinaMala commented 6 months ago

@duncansanderson Ready to be merged to develop