visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

Components: ToggleButton and ButtonToggle Group Naming #321

Open kyle-fraser opened 6 months ago

kyle-fraser commented 6 months ago

Summary of task

It's a bit confusing to have both a ToggleButton and ButtonToggleGroup as two distinct components with two distinct purposes and means of interaction. It would be good to initially review the naming of these components to see if there is a clearer way to denote them.

Additionally, this will let us review their use and function on the site if they should sit with something else inside the UI Kit (i.e. ToggleButton is an icon-only button but it is different from the rest of the button use since it is a circle and not square)

Acceptance criteria

Clearer names for the components in question. Next steps decided on the component separation in general.

Additional context

ToggleButton

ButtonToggleGroup