search

visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

336 psw location options being read aloud as blank #358

Closed duncansanderson closed 3 months ago

duncansanderson commented 3 months ago

The vue3-simple-typeahead component has an accessibility issue where the options are read out, by a screen reader, as "Blank" when using the keyboard to navigation through the list of options. I've replaced this component with a @headlessui/vue component, which is accessible.

GemmaLouise commented 3 months ago

@duncansanderson I had a look at the new one and it seems to be like reeeally slow when deleting the text and trying to enter a new location - not sure if just me or an issue with the plugin?

duncansanderson commented 3 months ago

@GemmaLouise - I've now replaced the @headlessui/vue component with another component called vue-comboblocks`, which appears to be much faster and a little easier to work with. I've also removed SCSS for the original component. Could you re-review these changes please?