visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

Remove UUID package, and externalise mapbox #364

Closed mjpvs closed 2 months ago

mjpvs commented 3 months ago

Couple of small tweaks for the export version. That UUID library doesn't work properly in the SSR context, I'd previously replaced it in imageWithCaption with the native UID functionality from vue but this extends it to other instances (which I hadn't noticed because they're not yet in use in business events) and removes the library entirely. It also externalises mapbox, so any package that wants to consume this will have to install that themselves but cuts the bundle size down a lot for sites that don't, preventing some awkward css code splits that were putting Warning and LoadingSpinner into their own separate css file as shared Map/Everything Else dependencies