visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

fix(typescript): fix declaration generation error with aliases #367

Closed mjpvs closed 2 months ago

mjpvs commented 2 months ago

Those odd errors in the build for product search were coming from the type declaration generation stage of the vite export. That does mean they shouldn't have caused any concrete errors but they were making things marginally less type safe; and they were specific to the product search because it's the only set of components we have that are marked as being in typescript (although they're not very consistently typed) since their import from the external package.

The change to the tsconfig allows those to find things within the @ alias properly, and the change to the store fixes another issue which that then brought up with types in components using the video store