visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

Feat/accessibility audit #368

Closed mjpvs closed 2 months ago

mjpvs commented 2 months ago

This fixes almost all of the violations raised by the storybook accessibility plugin we're using - some from the actual components and some from the dom structure used in the story. I think most of those are specific to the stories and are actually correct in .com/business events where the components are used but I'll check each of them.

The one that is still there is in tabs, a disabled tab doesn't get marked as aria-disabled properly so it complains about the colour contrast, where an actually disabled element will just be ignored. Updating to more recent versions of Bootstrap Vue Next (latest version is 0.20, we're on 0.9) fixes that but they have a load of side effects in the dom of components which is going to be a pain to tidy up, and there seems to be a bug with modals in the very latest version. At some point that will have to be its own separate task.