search

visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

refactor(padding and margin utiliies): replace suffixes to use new sp… #426

Closed markup-mitchell closed 1 month ago

markup-mitchell commented 1 month ago

…acer- schema

All p and m utilities, t,b,r,l,x,y,s,e and responsive variants updated to use new spacer- schema

markup-mitchell commented 1 month ago

@duncansanderson @mjpvs can I get your eyes on this early doors if possible? I want to get it into v4 before it needs further reconciliation. It's tedious, but we need to get it out the way.

markup-mitchell commented 1 month ago

I resisted the urge to anticipate "for consistency" as a reason, but I knew it was coming! IMO consistency is a means to an end and and we should be able to articulate what the trade-off is. I don't think we currently do use $spacer-0 in a consistent way: a quick search for margin: returns literally dozens of examples of 0 being used - more, in fact, than with the variable, from what I can see.

Anyway, I hope you don't mind that I went ahead and merged on the basis of the approvals I had just to get moving. I've created a ticket (DS-537) to replace 0 with the var as a separate task.